feat(web-console): export parquet files, fix unresponsive CSV imports #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrberk
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for exporting query results in Parquet format alongside the existing CSV export functionality and fixes an issue with unresponsive CSV imports by implementing a service worker-based download mechanism.
- Introduces Parquet export format with fallback download strategies
- Implements a service worker to handle authenticated download requests
- Refactors UI to show a dropdown menu for export format selection with loading states
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web-console/webpack.config.js |
Adds public directory to webpack copy patterns |
packages/web-console/src/utils/serviceWorker.ts |
New service worker registration and auth token management |
packages/web-console/src/utils/questdb/client.ts |
Refactored export method to support multiple formats with service worker integration |
packages/web-console/src/scenes/Result/index.tsx |
Updated UI with dropdown export menu and loading states |
packages/web-console/src/scenes/Search/SearchPanel.tsx |
Replaced custom loader with reusable LoadingSpinner component |
packages/web-console/src/components/LoadingSpinner/index.tsx |
New reusable loading spinner component |
packages/web-console/src/index.tsx |
Registers download service worker on app startup |
packages/web-console/public/download-sw.js |
Service worker implementation for handling authenticated downloads |
packages/web-console/serve-dist.js |
Added export endpoint to development proxy |
packages/browser-tests/cypress/integration/console/download.spec.js |
Comprehensive test coverage for new download functionality |
Comments suppressed due to low confidence (1)
packages/web-console/public/download-sw.js:1
- [nitpick] String literal should use double quotes to match the project's style. Change to
iframe.style.display = \"none\".
let authToken = null
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.